patches flaky test_rpc_slot_updates #26593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_rpc_slot_updates fails if SlotUpdate::Completed is received after SlotUpdate::Frozen: https://github.com/solana-labs/solana/blob/dcfd823ca/rpc-test/tests/rpc.rs#L198-L228 However, SlotUpdate::Completed is sent asynchronous to banking-stage and replay when shreds are inserted into blockstore. When the leader generates blocks, replay may freeze the bank before shreds are all inserted into blockstore; and so SlotUpdate::Completed may be received _after_ SlotUpdate::Frozen. The commit removes the ordering check for SlotUpdate::Completed.
|
@jstarry does this change make sense to you? |
jstarry
approved these changes
Jul 14, 2022
Lcchy
pushed a commit
to Bonfida/solana
that referenced
this pull request
Jul 22, 2022
test_rpc_slot_updates fails if SlotUpdate::Completed is received after SlotUpdate::Frozen: https://github.com/solana-labs/solana/blob/dcfd823ca/rpc-test/tests/rpc.rs#L198-L228 However, SlotUpdate::Completed is sent asynchronous to banking-stage and replay when shreds are inserted into blockstore. When the leader generates blocks, replay may freeze the bank before shreds are all inserted into blockstore; and so SlotUpdate::Completed may be received _after_ SlotUpdate::Frozen. The commit removes the ordering check for SlotUpdate::Completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
test_rpc_slot_updatesfails ifSlotUpdate::Completedis received afterSlotUpdate::Frozen:https://github.com/solana-labs/solana/blob/dcfd823ca/rpc-test/tests/rpc.rs#L198-L228
However,
SlotUpdate::Completedis sent asynchronous to banking-stage andreplay when shreds are inserted into blockstore. When the leader
generates blocks, replay may freeze the bank before shreds are all
inserted into blockstore; and so
SlotUpdate::Completedmay be receivedafter
SlotUpdate::Frozen.Summary of Changes
The commit removes the ordering check for SlotUpdate::Completed.